Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: add .golangci.yml ; examples/docker.yaml: update Ubuntu to 21.10 #364

Merged
merged 2 commits into from
Oct 26, 2021

Conversation

AkihiroSuda
Copy link
Member

@AkihiroSuda AkihiroSuda added the area/test Tests and CI label Oct 25, 2021
@AkihiroSuda AkihiroSuda added this to the v0.7.3 milestone Oct 25, 2021
@AkihiroSuda AkihiroSuda changed the title CI: add .golangci.yml CI: add .golangci.yml ; @AkihiroSuda examples/docker.yaml: update Ubuntu to 21.10 Oct 26, 2021
@AkihiroSuda AkihiroSuda changed the title CI: add .golangci.yml ; @AkihiroSuda examples/docker.yaml: update Ubuntu to 21.10 CI: add .golangci.yml ; examples/docker.yaml: update Ubuntu to 21.10 Oct 26, 2021
Copy link
Member

@jandubois jandubois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me; but I haven't reviewed the linter config in details. I trust the containerd config provides a good starting point.

@AkihiroSuda AkihiroSuda merged commit f46dd6c into lima-vm:master Oct 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/test Tests and CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants