Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HostResolver shouldn't return IPv6 addresses by default #547

Merged
merged 1 commit into from
Jan 13, 2022

Conversation

jandubois
Copy link
Member

They don't work over the SLIRP interface, and sometimes don't even work over a bridged vmnet interface.

See also rancher-sandbox/rancher-desktop#1193

This PR deprecates the useHostResolver setting and replaces it with hostResolver.enabled. The old setting can still be used, but if the new property is set, any old setting in the same file is being ignored. Generating proper warnings gets pretty complex when the interaction between default.yaml, lima.yaml, and override.yaml have to be considered.

It could be argued that HostResolver.LookupIPv6 should default to true for compatibility with previous releases. However, given that it seems to be broken in some setups, disabling IPv6 by default seems like a safer choice to me.

Also includes one bug fix for limactl debug dns 5533 5533, which previously ignored the TCP port.

Aside: I needed to include the TCP port during testing because limactl debug dns 5533 (without -6) option resulted in:

$ dig @127.0.0.1 -p 5533 AAAA google.com
;; Truncated, retrying in TCP mode.
;; Connection to 127.0.0.1#5533(127.0.0.1) for google.com failed: connection refused.

@jandubois jandubois added this to the v0.8.1 milestone Jan 13, 2022
@jandubois jandubois force-pushed the no-ipv6 branch 2 times, most recently from 565316d to f728800 Compare January 13, 2022 00:41
They don't work over the SLIRP interface, and sometimes don't
even work over a bridged vmnet interface.

Signed-off-by: Jan Dubois <[email protected]>
Copy link
Member

@AkihiroSuda AkihiroSuda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@jandubois jandubois merged commit 9e7ee97 into lima-vm:master Jan 13, 2022
@jandubois jandubois deleted the no-ipv6 branch January 13, 2022 06:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants