Skip to content

Commit

Permalink
fix: added second argument and warning to useAttrs- functions
Browse files Browse the repository at this point in the history
  • Loading branch information
Simon Milfred committed May 3, 2024
1 parent ffd4efd commit 9e658d2
Show file tree
Hide file tree
Showing 2 changed files with 12 additions and 7 deletions.
9 changes: 6 additions & 3 deletions composables/useAttrsExcept.js
Original file line number Diff line number Diff line change
@@ -1,7 +1,10 @@
export const useAttrsExcept = (excludes) => {
const attrs = useAttrs();
export default function useAttrsExcept(excludes, $attrs) {
/* useAttrs() causes problems, so do pass in $attrs */
const attrs = $attrs || useAttrs();
const attrsToReturn = reactive({});

!$attrs && console.warn('useAttrsExcept() needs a second argument, an attrs object, to function properly. UseAttrs() causes problems.')

watch(
() => attrs,
() => {
Expand All @@ -17,4 +20,4 @@ export const useAttrsExcept = (excludes) => {
);

return attrsToReturn;
};
}
10 changes: 6 additions & 4 deletions composables/useAttrsSome.js
Original file line number Diff line number Diff line change
@@ -1,12 +1,14 @@
export const useAttrsSome = (subset) => {
const attrs = useAttrs();
export default function useAttrsSome(subset, $attrs) {
/* useAttrs() causes problems, so do pass in $attrs */
const attrs = $attrs || useAttrs();
const attrsToReturn = reactive({});

!$attrs && console.warn('useAttrsSome() needs a second argument, an attrs object, to function properly. UseAttrs() causes problems.')

watch(
() => attrs,
() => {
subset ??= [];

for (const key in attrs) {
if (subset.includes(key)) {
attrsToReturn[key] = attrs[key];
Expand All @@ -17,4 +19,4 @@ export const useAttrsSome = (subset) => {
);

return attrsToReturn;
};
}

0 comments on commit 9e658d2

Please sign in to comment.