Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Call both native and script _setup/_enter/_exit in BTTask #227

Merged
merged 2 commits into from
Nov 1, 2024

Conversation

limbonaut
Copy link
Owner

@limbonaut limbonaut commented Sep 22, 2024

Current behavior is overriding, which is not correct, as these functions are more like "extension" than "override".

@limbonaut limbonaut added the bug Something isn't working label Sep 22, 2024
@limbonaut limbonaut marked this pull request as draft September 22, 2024 13:07
Current behavior is overriding, which is not correct as it's an initializer function.
@limbonaut limbonaut changed the title Call both native and script's _setup() in BTTask Call both native and script _setup/_enter/_exit in BTTask Nov 1, 2024
@limbonaut limbonaut marked this pull request as ready for review November 1, 2024 12:56
@limbonaut limbonaut merged commit 6de8b9e into master Nov 1, 2024
17 checks passed
@limbonaut limbonaut deleted the fix-bttask-setup-overriding branch November 1, 2024 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant