Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix chunk upload with ChunkedStreamReader to cancel underlying stream #920

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix chunk upload with ChunkedStreamReader to cancel underlying stream #920

wants to merge 1 commit into from

Conversation

hoangdat
Copy link
Member

@hoangdat hoangdat commented Feb 1, 2023

Root cause:

  • can not free resource when file.openRead() for each chunk

Solution:

  • using ChunkStreamReader to cancel the underlying stream

@hoangdat hoangdat temporarily deployed to dev February 1, 2023 10:20 — with GitHub Actions Inactive
@hoangdat hoangdat temporarily deployed to dev February 1, 2023 10:20 — with GitHub Actions Inactive
dab246
dab246 reviewed Feb 1, 2023
View reviewed changes
Copy link
Member

@dab246 dab246 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check case: _chunkedStreamReader?.cancel(); when upload failed

@hoangdat hoangdat temporarily deployed to dev February 1, 2023 15:08 — with GitHub Actions Inactive
@hoangdat hoangdat temporarily deployed to dev February 1, 2023 15:08 — with GitHub Actions Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dab246 dab246 dab246 left review comments

@nqhhdev nqhhdev nqhhdev approved these changes

@ManhNTX ManhNTX Awaiting requested review from ManhNTX

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hoangdat @dab246 @nqhhdev