TF-3256 Update index.html cache config #3263
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please further explain the dark magic going on in here. Cc @guimard |
4 months ago we updated our workflows to use Flutter 3.22.2. Per https://docs.flutter.dev/platform-integration/web/initialization:
We updated the Flutter version, but not follow it up with the new cache config that comes with it. This MAY fix it. Need to deploys to dev to test it first. |
hoangdat
changed the title
tddang-linagora
force-pushed
the
fixbug/TF-3256-tmail-web-cache-config
branch
2 times, most recently
from
1a2e593
to
f1bd3c3
Compare
hoangdat
reviewed
Nov 15, 2024
|
|
||
| ## Consequences | ||
|
|
||
| - Twake Mail web use cache resources to improve performance <img src="../images/after-flutter-3.22.png"> |
There was a problem hiding this comment.
IMO, it still not clear about the result of your change with this image. We should mention that: static files, main.dart.js only re-fetch in hard refresh. Open app, and refresh, not make any request to server side.
tddang-linagora
force-pushed
the
fixbug/TF-3256-tmail-web-cache-config
branch
from
f1bd3c3
to
0ee45a8
Compare
hoangdat
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Reference
Resolved
Updating