Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TW-2099: Design review v2.6.7 #2101

Merged
merged 7 commits into from
Oct 30, 2024
Merged

TW-2099: Design review v2.6.7 #2101

merged 7 commits into from
Oct 30, 2024

Conversation

nqhhdev
Copy link
Member

@nqhhdev nqhhdev commented Oct 22, 2024 •
edited
Loading

Ticket

Resolved:

  • Menu background
Screenshot 2024-10-23 at 10 10 09 Screenshot 2024-10-23 at 10 10 16 Screenshot 2024-10-23 at 10 10 29 Screenshot 2024-10-23 at 10 10 44 Screenshot 2024-10-23 at 10 11 14
  • Padding for chat list item
Screenshot 2024-10-22 at 15 44 14 Screenshot 2024-10-22 at 15 52 54
  • Update padding in chat
Screenshot 2024-10-24 at 01 14 18 Screenshot 2024-10-24 at 01 33 22

@github-actions GitHub Actions
Copy link

This PR has been deployed to https://linagora.github.io/twake-on-matrix/2101

@hoangdat
Copy link
Member

hoangdat commented Oct 23, 2024 •
edited by nqhhdev
Loading

  • should align also the composer
image

@nqhhdev nqhhdev force-pushed the TW-2099-design-review-v2.6.7 branch from de3e550 to ab08afd Compare October 24, 2024 02:46
@hoangdat
Copy link
Member

  • align message bubble of Direct chat
Screenshot 2024-10-24 at 10 03 18

@nqhhdev nqhhdev force-pushed the TW-2099-design-review-v2.6.7 branch from ab08afd to f73c3e3 Compare October 24, 2024 03:52
@hoangdat
Copy link
Member

hoangdat commented Oct 25, 2024 •
edited by nqhhdev
Loading

  • back button in web still not correct in web app
Screenshot 2024-10-25 at 15 11 16 Screenshot 2024-10-25 at 15 11 06 Screenshot 2024-10-25 at 15 10 56

@nqhhdev
Copy link
Member Author

nqhhdev commented Oct 25, 2024

hi @hoangdat , I fixed all the comments and pushed it. pls help me review again

hoangdat
hoangdat reviewed Oct 28, 2024
View reviewed changes
ios/Podfile Outdated
Comment on lines 36 to 38
# target 'Twake Share' do
# inherit! :search_paths
# end
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why we need it?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reverted

hoangdat
hoangdat reviewed Oct 28, 2024
View reviewed changes
ios/Runner.xcodeproj/project.pbxproj Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

idem

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reverted

@nqhhdev nqhhdev force-pushed the TW-2099-design-review-v2.6.7 branch from 5c75faa to 4d73db0 Compare October 29, 2024 11:34
@hoangdat hoangdat merged commit f8d3a83 into main Oct 30, 2024
7 checks passed
@hoangdat hoangdat deleted the TW-2099-design-review-v2.6.7 branch October 30, 2024 02:56
@nqhhdev nqhhdev mentioned this pull request Nov 7, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KhaledNjim KhaledNjim KhaledNjim left review comments

@hoangdat hoangdat hoangdat approved these changes

@sherlockvn sherlockvn Awaiting requested review from sherlockvn

@dab246 dab246 Awaiting requested review from dab246 dab246 is a code owner

@hieutbui hieutbui Awaiting requested review from hieutbui

@tddang-linagora tddang-linagora Awaiting requested review from tddang-linagora tddang-linagora is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nqhhdev @hoangdat @KhaledNjim