Add issueStatelessChannelToken test #607
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yang-33
approved these changes
Aug 15, 2024
| body: json_encode(['access_token' => 'accessToken', 'expires_in' => 30, 'token_type' => 'Bearer',]), | ||
| )); | ||
| $api = new ChannelAccessTokenApi($client); | ||
| $response = $api->issueStatelessChannelToken("client_credentials", |
There was a problem hiding this comment.
How about explicitly using required arguments to work tests even if new optional argument is required?
issueStatelessChannelToken(grantType: "client_credentials", clientId: "1234", clientSecret: "channelSecret")
There was a problem hiding this comment.
Yes, I'll do that. In fact, I think that this is also the more common use case for users.
eucyt
commented
Aug 16, 2024
| @@ -0,0 +1,59 @@ | |||
| <?php | |||
There was a problem hiding this comment.
I realized that since it was a test for a different API class, it should be in a separate test class 🙏
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/oauth2/v3/tokenrequires only 3 parameters, but client requires 5 parameters. Our client must work even if some of arguments are passednulllikeclient.issueStatelessChannelToken("client_credentials", null, null, "1234", "clientSecret"). This change adds a test to verify this.