Add sharing selected target view and slide in / out animation #31
Conversation
eJamesLin
changed the title
eJamesLin
force-pushed
the
feature/selected-share-target-view
branch
from
e009096
to
298e624
Compare
eJamesLin
changed the base branch from
feature/share-table-view-controller
to
v5.2
Codecov Report
@@ Coverage Diff @@
## v5.2 #31 +/- ##
=========================================
- Coverage 80.57% 79.48% -1.1%
=========================================
Files 163 164 +1
Lines 6385 6473 +88
=========================================
Hits 5145 5145
- Misses 1240 1328 +88
Continue to review full report at Codecov.
|
| enum Design { | ||
| static let height = CGFloat(79) | ||
| static let bgColor = "#F7F8FA" | ||
| static let borderColor = "#E6E7EA" |
There was a problem hiding this comment.
Can you change the Design as the ones in #30
- Use a
vargetter instead ofletstored property (to make the memory a bit cleaner) - Use
UIColor(hex6:)for colors instead ofString(to make it more efficient) - Add all design style related things here, like
borderWidth,backgroundColor, etc.
There was a problem hiding this comment.
ok. let me modified.
| @objc | ||
| func foo() { | ||
| selectedTargetView.mode = (selectedTargetView.mode == .show) ? .hide : .show | ||
| selectedTargetView.updateLayout(withAnimated: true) |
There was a problem hiding this comment.
It seems that every mode changing is bound to a call of updateLayout(withAnimated:). Can we combine these two, hide both mode and updateLayout as private, then provide an easier API like setMode(_ mode: Mode, animated: Bool)?
|
|
||
| var mode = Mode.hide | ||
|
|
||
| func updateLayout(withAnimated animated: Bool) { |
There was a problem hiding this comment.
The API name is not common. Maybe updateLayout(animated flag: Bool) would be more swifty. See the similar one from Apple.
There was a problem hiding this comment.
Or you can call it "withAnimation:", but that indicates that you want to pass an animation object which can define what exactly the animation is. For a Bool, I guess it is proper to use xxx(animated:)
| yAnchor = view.safeAreaLayoutGuide.bottomAnchor | ||
| } else { | ||
| yAnchor = bottomLayoutGuide.topAnchor | ||
| } |
There was a problem hiding this comment.
| static let borderColor = "#E6E7EA" | ||
| } | ||
|
|
||
| private var slideAnimationViewTopConstraint: NSLayoutConstraint? |
There was a problem hiding this comment.
Since slideAnimationViewTopConstraint would be always there unless a programmer error happens. So let's change it to NSLayoutConstraint! to make the failure explicitly.
… to make the memory a bit cleaner, applied UIColor(hex6:)
| self.alpha = alpha | ||
| self.layoutIfNeeded() | ||
| } | ||
| } |
There was a problem hiding this comment.
I guess if animated == false, the alpha is not getting updated now. Maybe we also need the case for non-animated?
There was a problem hiding this comment.
And I suggest also call layoutIfNeeded() in the animated == false statement, to trigger an immediate layout. Otherwise, any code depends on the layout would not work until the next main run loop, which causes confusion.
There was a problem hiding this comment.
Indeed, I missed the alpha setup in no animation case.
Agree. the layoutIfNeeded in animated == false will be more clear.
About
Note