-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Swift Package Manager support #70
Conversation
👍 Kind of pity that user could not open the sample project by Xcode10 once merged. |
I guess we will not merge it until Xcode 11 officially released. But fortunately it just affect the sample project. Carthage users can still build the LineSDK.framework target without problem even using Xcode 10. |
@eJamesLin I removed the sample app using SPM, so it now can be opened without problem in Xcode 10 too. I guess it would be a good time to merge it since it is a better starting point for the binary framework feature. |
# Conflicts: # LineSDK/LineSDK/Utils/Constant.swift # LineSDK/LineSDK/Utils/Helpers.swift
This pull request contains support for the newly added Swift Package Manager (SPM) support of Xcode 11.
From Xcode 11, it supports to build a library against UIKit with SPM. That means we can use it to provide an easier way to integrate our SDK into user's project. I modified some of the project files/settings to let this project compatible with SPM. There is also a new sample app target
LineSDKSample(SPM)
to verify the behavior when building with SPM.Some concerns and things not contained yet:
LoginButton
and all localization files, and the new sharing UI planned to be added in next version. It is proposed in this file, maybe we can see it next year.LineSDK
target now supports SPM. Our ObjC wrapperLineSDKObjC
is not yet. I wonder whether it worths or be possible to do so. Since the ObjC wrapper is also a Swift project and it should be just a subset of using Swift features, it is possible to also provide SPM support for it. However, users of this wrapper is using our SDK through Objective-C, I don't know whether users can get any benefit from SPM when using Objective-C as their language.swiftLanguageVersions
andtestTarget
in thePackage.swift
to make it better.@rmundo @eJamesLin Can you check and try it in your environments to verify the correctness of these implementation? Thanks!