Adopt provider metadata issuer from discovery document when doing token verification #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… instead of a fixed value.
onevcat
reviewed
Jul 29, 2019
| @@ -288,7 +290,7 @@ extension LoginManager { | |||
| func getJWK( | |||
There was a problem hiding this comment.
Let's rename this method to something like getProviderMetadata
There was a problem hiding this comment.
indeed. got it~ thanks~
onevcat
reviewed
Jul 29, 2019
| @@ -334,12 +336,12 @@ extension LoginManager { | |||
| } | |||
| } | |||
|
|
|||
| func verifyIDToken(_ token: JWT, key: JWK, process: LoginProcess, userID: String?) throws { | |||
| func verifyIDToken(_ token: JWT, expected: DiscoveryDocument.ResolvedProviderMetadata, process: LoginProcess, userID: String?) throws { | |||
There was a problem hiding this comment.
I prefer some new line to make the code not extending too much. Can you set the "Page Guide" at column 120?
There was a problem hiding this comment.
oh, thanks for the remind. My previous page guide seems gone after switching between Xcode 10/11 😂
onevcat
reviewed
Jul 29, 2019
| @@ -187,7 +187,9 @@ public class LoginManager { | |||
| let group = DispatchGroup() | |||
|
|
|||
| var profile: UserProfile? | |||
| var webToken: JWK? | |||
|
|
|||
| var expected: DiscoveryDocument.ResolvedProviderMetadata? | |||
There was a problem hiding this comment.
I suggest providerMetadata a better name. The issuer is the expected value, but the JWK is not what is expected, it is just a key to be used while verification.
eJamesLin
force-pushed
the
Adopt-OpenID-discovery-document-in-token-verification
branch
from
f16acde
to
247258a
Compare
eJamesLin
force-pushed
the
Adopt-OpenID-discovery-document-in-token-verification
branch
from
247258a
to
0d6389a
Compare
|
It's nice! |
eJamesLin
deleted the
Adopt-OpenID-discovery-document-in-token-verification
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About