Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop CocoaPods and Carthage, use built-in xcframework #46

Merged
merged 4 commits into from
Jan 5, 2023

Conversation

onevcat
Copy link
Member

@onevcat onevcat commented Dec 6, 2022

This PR contains these changes:

  • Remove the related post-build script for adding LINE SDK Swift by CocoaPods or Carthage.
  • Remove the settings of LINE SDK for switching between CocoaPods and Carthage.
  • Add the prebuilt xcframework to the project.
  • Add a new post-build script to add the xcframework to the exported Xcode project. (Unity now only supports adding .framework automatically so we have to add the xcframework ourselves).

I will also update the documentation to reflect this change too after it can be merged. The existing users have to remove the old package and re-import the new one to get rid of the outdated (removed) CocoaPods/Carthage scripts. But there is no API changes so I guess we can release it as a minor version, something like 1.2.0 for example.

@eJamesLin
Copy link

eJamesLin commented Dec 14, 2022

It's cool to adopt native xcframework 👍 👍 👍

I'm not familiar with Unity, not sure if lots of .meta files are required to be in git.
Also the Localizable.strings might have unrelated strings.

@onevcat
Copy link
Member Author

onevcat commented Dec 15, 2022

The meta files are automatically generated by Unity when importing any files into the project. In this PR, most are not used and tracking nothing, but in deed some of them are important, such as this one. It records the fact that we do not want Unity to merely copy the framework file to the Xcode project (the whole xcframework should be treated and used as one in whole). So we need to leave it at least.

For other not in use ones, since Unity will just also generate them when the user importing them, I guess it would be no harm to leave as they are now. In the post build script we are making sure to remove the meta to prevent it from being copied to the final exported Xcode project, where they are not necessary at all.

Copy link

@eJamesLin eJamesLin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ynaoto
Copy link

ynaoto commented Dec 26, 2022

When can I expect to have new release that includes this change? This would be very useful for me to drive automated build.

@onevcat
Copy link
Member Author

onevcat commented Dec 26, 2022

I wish I could prepare a release tag for it as soon as possible, but unfortunately I am already on vacation now and cannot reach my working computer. So I am afraid I have to do it after the new year. Does that sound fine to you?

@onevcat
Copy link
Member Author

onevcat commented Dec 26, 2022

Before that, it is totally fine to use this branch to get these changes!

@ynaoto
Copy link

ynaoto commented Dec 27, 2022

It would be great if I may have the new package in the early new year. Enjoy your holodays!

@onevcat
Copy link
Member Author

onevcat commented Jan 5, 2023

I will merge it for now and going to write a new installation guide for it. Once the documentation can be done, I will tag it and make a new release.

@onevcat onevcat merged commit dcea1ad into master Jan 5, 2023
@onevcat
Copy link
Member Author

onevcat commented Jan 11, 2023

The new version 1.2.0 was released with these changes. I am going to delete the fix/ios-integration branch for now and please switch to using the released version instead.

Thanks!

@onevcat onevcat deleted the fix/ios-integration branch January 11, 2023 04:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants