-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop CocoaPods and Carthage, use built-in xcframework #46
Conversation
It's cool to adopt native xcframework 👍 👍 👍 I'm not familiar with Unity, not sure if lots of .meta files are required to be in git. |
The meta files are automatically generated by Unity when importing any files into the project. In this PR, most are not used and tracking nothing, but in deed some of them are important, such as this one. It records the fact that we do not want Unity to merely copy the For other not in use ones, since Unity will just also generate them when the user importing them, I guess it would be no harm to leave as they are now. In the post build script we are making sure to remove the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
When can I expect to have new release that includes this change? This would be very useful for me to drive automated build. |
I wish I could prepare a release tag for it as soon as possible, but unfortunately I am already on vacation now and cannot reach my working computer. So I am afraid I have to do it after the new year. Does that sound fine to you? |
Before that, it is totally fine to use this branch to get these changes! |
It would be great if I may have the new package in the early new year. Enjoy your holodays! |
I will merge it for now and going to write a new installation guide for it. Once the documentation can be done, I will tag it and make a new release. |
The new version 1.2.0 was released with these changes. I am going to delete the Thanks! |
This PR contains these changes:
.framework
automatically so we have to add thexcframework
ourselves).I will also update the documentation to reflect this change too after it can be merged. The existing users have to remove the old package and re-import the new one to get rid of the outdated (removed) CocoaPods/Carthage scripts. But there is no API changes so I guess we can release it as a minor version, something like 1.2.0 for example.