Add support for setting channelID afterwards #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@k0uhe1D Please check it and let me know if this can be a possible fix for your case. Thanks! |
k0uhe1D
approved these changes
Jan 24, 2024
|
|
||
| if (!string.IsNullOrEmpty(channelID)) { | ||
| SetupSDK(); | ||
| } |
There was a problem hiding this comment.
Suggested change
| } | |
| } else { | |
| Debug.LogWarning("LINE SDK channel ID is not set."); | |
| } |
There was a problem hiding this comment.
I considered to add an else here but decided not to do that finally. If we treat "leaving empty and calling Setup manually" as a possible and normal case, we should not produce a warning for this case.
Instead, an SDK error and/or the exception in Setup method will play the role of telling something goes wrong.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This can improve the usability of
LineSDK, giving it a way to setchannelIDafter theAwakeis called. Fixes #67