You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Not sure exactly what's going on here, but it looks a bit suspicious:
I am not sure why we need to finish calls. For reference, I believe the code @jneem is referring to is in the render function
fnrender(&self) -> bool{self.context.clear_rect(0.0,0.0,self.get_width()asf64,self.get_height()asf64);letmut piet_ctx = piet_common::Piet::new(self.context.clone(),self.window.clone());let want_anim_frame = self.handler.borrow_mut().paint(&mut piet_ctx);ifletErr(e) = piet_ctx.finish(){
log::error!("piet error on render: {:?}", e);}let res = piet_ctx.finish();ifletErr(e) = res {
log::error!("EndDraw error: {:?}", e);}
want_anim_frame
}
This part is over a year old. It does look redundant to me. After trying the examples without the second piet_ctx.finish(), I couldn't find any difference. I think it's safe to remove the second .finish() call.
Not sure exactly what's going on here, but it looks a bit suspicious:
I am not sure why we need to finish calls. For reference, I believe the code @jneem is referring to is in the render function
This part is over a year old. It does look redundant to me. After trying the examples without the second
piet_ctx.finish()
, I couldn't find any difference. I think it's safe to remove the second.finish()
call.Originally posted by @elrnv in #817 (comment)
The text was updated successfully, but these errors were encountered: