Simplify Scale by removing DPI. #1042
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xStrom
added
shell
jneem
reviewed
Jun 18, 2020
luleyleo
reviewed
Jun 18, 2020
There was a problem hiding this comment.
Looks like a good simplification!
I think it is useful to always link the reason for changes: #913 (comment)
luleyleo
added
S-waiting-on-author
xStrom
added
S-needs-review
|
Thanks, this is ready for another look. 👀 |
luleyleo
approved these changes
Jun 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes any notion of DPI from
Scaleand makes it strictly scale factor based.Previously
Scalealways considered 96 as the target DPI but with this change that decision is in the platform code's hands. This will allow for easier implementation of future platforms that have a different target DPI like Android with 160.This also means that all the DPI-related stuff can be an implementation detail and it doesn't need to be surfaced to developers using druid. Especially as DPI doesn't really match any actual inches etc.