Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TextAlignment support to TextLayout and Label #1210

Merged
merged 1 commit into from
Sep 11, 2020
Merged

Conversation

cmyr
Copy link
Member

@cmyr cmyr commented Sep 10, 2020

This also updates the 'text' example to demonstrate this feature.

Screen Shot 2020-09-10 at 12 25 40 PM
Screen Shot 2020-09-10 at 12 25 44 PM
Screen Shot 2020-09-10 at 12 25 49 PM
Screen Shot 2020-09-10 at 12 25 53 PM

CHANGELOG.md Outdated
@@ -429,6 +430,7 @@ Last release without a changelog :(
[#1195]: https://github.com/linebender/druid/pull/1195
[#1204]: https://github.com/linebender/druid/pull/1204
[#1205]: https://github.com/linebender/druid/pull/1205
[#1208]: https://github.com/linebender/druid/pull/1208
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should be 1210 (will fix this when I inevitably have to rebase)

@cmyr cmyr added the S-needs-review waits for review label Sep 10, 2020
@cmyr cmyr mentioned this pull request Sep 10, 2020
7 tasks
Base automatically changed from text-layout-width to master September 11, 2020 16:05
This also updates the 'text' example to demonstrate this feature.
Copy link
Contributor

@raphlinus raphlinus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks.

@cmyr cmyr merged commit bf93cf1 into master Sep 11, 2020
@cmyr cmyr deleted the text-alignment branch September 11, 2020 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-needs-review waits for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants