Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make platform-specific menus more portable #1339

Merged
merged 1 commit into from
Oct 29, 2020
Merged

Make platform-specific menus more portable #1339

merged 1 commit into from
Oct 29, 2020

Conversation

raphlinus
Copy link
Contributor

If an application were to misuse a platform-specific for the wrong
platform, it would get unusable keybindings. With this patch, it might
not be the most appropriate for the platform, but it would work.

The linked bug below suggests a more systematic approach, but this is a
minimal patch to get things to a less broken state.

Part of work tracked in #1306.

If an application were to misuse a platform-specific for the wrong
platform, it would get unusable keybindings. With this patch, it might
not be the most appropriate for the platform, but it would work.

The linked bug below suggests a more systematic approach, but this is a
minimal patch to get things to a less broken state.

Part of work tracked in #1306.
@cmyr cmyr added the S-needs-review waits for review label Oct 26, 2020
Copy link
Collaborator

@jneem jneem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This certainly seems like an improvement, but I'm a bit confused about the intended cross-platform usage of SysMods and RawMods. At least on linux, it's common for "meta" to refer to the "windows" key, but it seems that SysMods doesn't have it...

@raphlinus raphlinus merged commit 6a4062d into master Oct 29, 2020
@raphlinus
Copy link
Contributor Author

The lack of "meta" or "windows" in SysMods is intentional. On macOS, the "apple" or "command" key maps to "meta," which is SysMods::Cmd on that platform. It's also the case that the windows key on Windows can't be used as a hotkey modifier, as it seems to be intercepted by the system. A good way to think about SysMods is that it's the lowest common denominator of modifier keys.

This area can definitely use more refinement and documentation.

@raphlinus raphlinus deleted the menu_work4 branch October 29, 2020 15:22
@maan2003 maan2003 removed the S-needs-review waits for review label May 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants