Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempt to provide more info to @NatsuShio #1429

Merged
merged 1 commit into from
Dec 14, 2020

Conversation

derekdreery
Copy link
Collaborator

Provide more error information for #1426.

I haven't checked this as I'm on linux.

@derekdreery derekdreery force-pushed the log_win_rt_result branch 2 times, most recently from 23c9005 to e4efc69 Compare November 24, 2020 17:12
@cmyr
Copy link
Member

cmyr commented Dec 13, 2020

Has this outlived its useful life?

@derekdreery
Copy link
Collaborator Author

@cmyr I think this patch is an improvement that stands on its own irrespective of the original need. It provides more information on an error than previously.

Copy link
Member

@cmyr cmyr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair enough, better error reporting makes sense.

@derekdreery derekdreery merged commit 348a4ce into linebender:master Dec 14, 2020
@derekdreery derekdreery deleted the log_win_rt_result branch December 14, 2020 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants