Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add MouseButtons.count() #1500

Merged
merged 3 commits into from
Jan 5, 2021
Merged

Add MouseButtons.count() #1500

merged 3 commits into from
Jan 5, 2021

Conversation

jjl
Copy link
Contributor

@jjl jjl commented Jan 3, 2021

No description provided.

derekdreery
derekdreery approved these changes Jan 4, 2021
View reviewed changes
Copy link
Collaborator

@derekdreery derekdreery left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I wonder, does the function have to take a &mut, rather than &?

@jjl
Copy link
Contributor Author

jjl commented Jan 4, 2021

Good spot, sorted.

@derekdreery
Copy link
Collaborator

Ack, now clippy is complaining because the object is Copy. Would you change it from &self to self, then clippy will be happy.

@jjl
Copy link
Contributor Author

jjl commented Jan 5, 2021

Done. Hazards of thinking your chamge is too small to upset clippy...

@derekdreery derekdreery merged commit 69a8bcf into linebender:master Jan 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@derekdreery derekdreery derekdreery approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jjl @derekdreery