Implement Lens directly on a pair #1654
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Maybe we should implement |
|
@derekdreery does this make sense to you? I think so, but curious if you had a more specific need that required I've run into this before; I think it does make sense to have lenses on the tuples, maybe from rank 1-8? I think an 8-tuple is a horrible idea but I think it's okay as an upper bound.. |
|
@cmyr @derekdreery can we get this done? |
cmyr
approved these changes
Apr 11, 2021
|
@maan2003 Just noticed this doesn't have a matching changelog entry. Just want to make sure you have the chance if you forgot. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I see no reason not to implement it directly 🤷 and it feels more intuitive