Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set button border radius for each corner separately #2039

Merged

Conversation

ngugcx
Copy link
Contributor

@ngugcx ngugcx commented Nov 13, 2021

This PR sets the type of BUTTON_BORDER_RADIUS to RoundedRectRadii, which makes it able to set button border radius for each corner separately.

@maan2003
Copy link
Collaborator

because Env::set and Env::adding accept Into<V> this is not even a breaking change!

@ngugcx
Copy link
Contributor Author

ngugcx commented Nov 14, 2021

There are other radius keys.
I'll change them all to make the interfaces consitent.

pub const PROGRESS_BAR_RADIUS: Key<f64> =
    Key::new("org.linebender.druid.theme.progress_bar_radius");
--
pub const BUTTON_BORDER_RADIUS: Key<RoundedRectRadii> = Key::new("org.linebender.druid.theme.button_radius");
--
pub const TEXTBOX_BORDER_RADIUS: Key<f64> =
    Key::new("org.linebender.druid.theme.textbox_border_radius");
--
pub const SCROLLBAR_RADIUS: Key<f64> = Key::new("org.linebender.druid.theme.scrollbar_radius");

@ngugcx
Copy link
Contributor Author

ngugcx commented Nov 17, 2021

Why is the workflow not running? @maan2003

@maan2003
Copy link
Collaborator

It needed approval because you are first contributor. I have run it now.

@maan2003 maan2003 merged commit 782d25e into linebender:master Dec 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants