Xilem architecture async experiment

Cargo.toml

@@ -7,6 +7,7 @@ members = [
     "druid/examples/web",
     "druid/examples/hello_web",
     "druid/examples/value_formatting",
+    "idiopath",
 ]
 default-members = [
     "druid",

druid-shell/src/backend/mac/window.rs

@@ -1424,6 +1424,7 @@ unsafe impl HasRawWindowHandle for WindowHandle {
 }
 
 unsafe impl Send for IdleHandle {}
+unsafe impl Sync for IdleHandle {}
 
 impl IdleHandle {
     fn add_idle(&self, idle: IdleKind) {

idiopath/Cargo.toml

@@ -0,0 +1,11 @@
+[package]
+name = "idiopath"
+version = "0.1.0"
+authors = ["Raph Levien <[email protected]>"]
+edition = "2021"
+
+[dependencies]
+"druid-shell" = { path = "../druid-shell" }
+
+futures-task = "0.3"
+tokio = { version = "1", features = ["full"] }

idiopath/README.md

@@ -0,0 +1,77 @@
+# An experimental Rust architecture for reactive UI
+
+This repo contains an experimental architecture, implemented with a toy UI. At a very high level, it combines ideas from Flutter, SwiftUI, and Elm. Like all of these, it uses lightweight view objects, diffing them to provide minimal updates to a retained UI. Like SwiftUI, it is strongly typed.
+
+## Overall program flow
+
+Like Elm, the app logic contains *centralized state.* On each cycle (meaning, roughly, on each high-level UI interaction such as a button click), the framework calls a closure, giving it mutable access to the app state, and the return value is a *view tree.* This view tree is fairly short-lived; it is used to render the UI, possibly dispatch some events, and be used as a reference for *diffing* by the next cycle, at which point it is dropped.
+
+We'll use the standard counter example. Here the state is a single integer, and the view tree is a column containing two buttons.
+
+```rust
+fn app_logic(data: &mut u32) -> impl View<u32, (), Element = impl Widget> {
+    Column::new((
+        Button::new(format!("count: {}", data), |data| *data += 1),
+        Button::new("reset", |data| *data = 0),
+    ))
+}
+```
+
+These are all just vanilla data structures. The next step is diffing or reconciling against a previous version, now a standard technique. The result is an *element tree.* Each node type in the view tree has a corresponding element as an associated type. The `build` method on a view node creates the element, and the `rebuild` method diffs against the previous version (for example, if the string changes) and updates the element. There's also an associated state tree, not actually needed in this simple example, but would be used for memoization.
+
+The closures are the interesting part. When they're run, they take a mutable reference to the app data.
+
+## Components
+
+A major goal is to support React-like components, where modules that build UI for some fragment of the overall app state are composed together. 
+
+```rust
+struct AppData {
+    count: u32,
+}
+
+fn count_button(count: u32) -> impl View<u32, (), Element = impl Widget> {
+    Button::new(format!("count: {}", count), |data| *data += 1)
+}
+
+fn app_logic(data: &mut AppData) -> impl View<AppData, (), Element = impl Widget> {
+    Adapt::new(|data: &mut AppData, thunk| thunk.call(&mut data.count),
+        count_button(data.count))
+}
+```
+
+This adapt node is very similar to a lens (quite familiar to existing Druid users), and is also very similar to the [Html.map] node in Elm. Note that in this case the data presented to the child component to render, and the mutable app state available in callbacks is the same, but that is not necessarily the case.
+
+## Memoization
+
+In the simplest case, the app builds the entire view tree, which is diffed against the previous tree, only to find that most of it hasn't changed.
+
+When a subtree is a pure function of some data, as is the case for the button above, it makes sense to *memoize.* The data is compared to the previous version, and only when it's changed is the view tree build. The signature of the memoize node is nearly identical to [Html.lazy] in Elm:
+
+```rust
+n app_logic(data: &mut AppData) -> impl View<AppData, (), Element = impl Widget> {
+    Memoize::new(data.count, |count| {
+        Button::new(format!("count: {}", count), |data: &mut AppData| {
+            data.count += 1
+        })
+    }),
+}
+```
+
+The current code uses a `PartialEq` bound, but in practice I think it might be much more useful to use pointer equality on `Rc` and `Arc`.
+
+The combination of memoization with pointer equality and an adapt node that calls [Rc::make_mut] on the parent type is actually a powerful form of change tracking, similar in scope to Adapton, self-adjusting computation, or the types of binding objects used in SwiftUI. If a piece of data is rendered in two different places, it automatically propagates the change to both of those, without having to do any explicit management of the dependency graph.
+
+I anticipate it will also be possible to do dirty tracking manually - the app logic can set a dirty flag when a subtree needs re-rendering.
+
+## Optional type erasure
+
+By default, view nodes are strongly typed. The type of a container includes the types of its children (through the `ViewTuple` trait), so for a large tree the type can become quite large. In addition, such types don't make for easy dynamic reconfiguration of the UI. SwiftUI has exactly this issue, and provides [AnyView] as the solution. Ours is more or less identical.
+
+The type erasure of View nodes is not an easy trick, as the trait has two associated types and the `rebuild` method takes the previous view as a `&Self` typed parameter. Nonetheless, it is possible. (As far as I know, Olivier Faure was the first to demonstrate this technique, in [Panoramix], but I'm happy to be further enlightened)
+
+[Html.lazy]: https://guide.elm-lang.org/optimization/lazy.html
+[Html map]: https://package.elm-lang.org/packages/elm/html/latest/Html#map
+[Rc::make_mut]: https://doc.rust-lang.org/std/rc/struct.Rc.html#method.make_mut
+[AnyView]: https://developer.apple.com/documentation/swiftui/anyview
+[Panoramix]: https://github.com/PoignardAzur/panoramix

idiopath/src/app.rs

@@ -0,0 +1,139 @@
+// Copyright 2022 The Druid Authors.
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+//     http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+use std::sync::{Arc, Mutex};
+
+use druid_shell::{kurbo::Point, piet::Piet, WindowHandle};
+
+use crate::{
+    event::Event,
+    id::Id,
+    view::{Cx, View},
+    widget::{RawEvent, Widget},
+};
+
+pub struct App<T, V: View<T, ()>, F: FnMut(&mut T) -> V>
+where
+    V::Element: Widget,
+{
+    data: T,
+    app_logic: F,
+    view: Option<V>,
+    id: Option<Id>,
+    state: Option<V::State>,
+    element: Option<V::Element>,
+    events: Vec<Event>,
+    cx: Cx,
+    wake_queue: WakeQueue,
+}
+
+#[derive(Clone, Default)]
+pub struct WakeQueue(Arc<Mutex<Vec<Event>>>);
+
+impl<T, V: View<T, ()>, F: FnMut(&mut T) -> V> App<T, V, F>
+where
+    V::Element: Widget,
+{
+    pub fn new(data: T, app_logic: F) -> Self {
+        let wake_queue = Default::default();
+        let cx = Cx::new(&wake_queue);
+        App {
+            data,
+            app_logic,
+            view: None,
+            id: None,
+            state: None,
+            element: None,
+            events: Vec::new(),
+            cx,
+            wake_queue,
+        }
+    }
+
+    pub fn ensure_app(&mut self) {
+        if self.view.is_none() {
+            let view = (self.app_logic)(&mut self.data);
+            let (id, state, element) = view.build(&mut self.cx);
+            self.view = Some(view);
+            self.id = Some(id);
+            self.state = Some(state);
+            self.element = Some(element);
+        }
+    }
+
+    pub fn connect(&mut self, window_handle: WindowHandle) {
+        self.cx.set_handle(window_handle.get_idle_handle());
+    }
+
+    pub fn paint(&mut self, piet: &mut Piet) {
+        self.ensure_app();
+        let element = self.element.as_mut().unwrap();
+        element.layout();
+        element.paint(piet, Point::ZERO);
+    }
+
+    pub fn mouse_down(&mut self, point: Point) {
+        self.event(RawEvent::MouseDown(point));
+    }
+
+    fn event(&mut self, event: RawEvent) {
+        self.ensure_app();
+        let element = self.element.as_mut().unwrap();
+        element.event(&event, &mut self.events);
+        self.run_app_logic();
+    }
+
+    pub fn run_app_logic(&mut self) {
+        for event in self.events.drain(..) {
+            let id_path = &event.id_path[1..];
+            self.view.as_ref().unwrap().event(
+                id_path,
+                self.state.as_mut().unwrap(),
+                event.body,
+                &mut self.data,
+            );
+        }
+        // Re-rendering should be more lazy.
+        let view = (self.app_logic)(&mut self.data);
+        view.rebuild(
+            &mut self.cx,
+            self.view.as_ref().unwrap(),
+            self.id.as_mut().unwrap(),
+            self.state.as_mut().unwrap(),
+            self.element.as_mut().unwrap(),
+        );
+        assert!(self.cx.is_empty(), "id path imbalance on rebuild");
+        self.view = Some(view);
+    }
+
+    pub fn wake_async(&mut self) {
+        let events = self.wake_queue.take();
+        self.events.extend(events);
+        self.run_app_logic();
+    }
+}
+
+impl WakeQueue {
+    // Returns true if the queue was empty.
+    pub fn push_event(&self, event: Event) -> bool {
+        let mut queue = self.0.lock().unwrap();
+        let was_empty = queue.is_empty();
+        queue.push(event);
+        was_empty
+    }
+
+    pub fn take(&self) -> Vec<Event> {
+        std::mem::replace(&mut self.0.lock().unwrap(), Vec::new())
+    }
+}

idiopath/src/event.rs

@@ -0,0 +1,33 @@
+// Copyright 2022 The Druid Authors.
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+//     http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+use std::any::Any;
+
+use crate::id::IdPath;
+
+pub struct Event {
+    pub id_path: IdPath,
+    pub body: Box<dyn Any + Send>,
+}
+
+pub struct AsyncWake;
+
+impl Event {
+    pub fn new(id_path: IdPath, event: impl Any + Send) -> Event {
+        Event {
+            id_path,
+            body: Box::new(event),
+        }
+    }
+}

idiopath/src/id.rs

@@ -0,0 +1,34 @@
+// Copyright 2022 The Druid Authors.
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+//     http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+use std::num::NonZeroU64;
+
+#[derive(Clone, Copy, Debug, PartialEq, Eq, PartialOrd, Hash)]
+/// A stable identifier for an element.
+pub struct Id(NonZeroU64);
+
+pub type IdPath = Vec<Id>;
+
+impl Id {
+    /// Allocate a new, unique `Id`.
+    pub fn next() -> Id {
+        use druid_shell::Counter;
+        static WIDGET_ID_COUNTER: Counter = Counter::new();
+        Id(WIDGET_ID_COUNTER.next_nonzero())
+    }
+
+    pub fn to_raw(self) -> u64 {
+        self.0.into()
+    }
+}