Replace lazy_static with once_cell #2263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
notgull
reviewed
Sep 21, 2022
There was a problem hiding this comment.
The only real issue I have with this is the inclusion of version 1.15.0 of OnceCell, which includes a dramatic MSRV bump to rustc 1.56. I'm not sure what the MSRV policy is for Druid, but if it's lower than 1.56 this could introduce an unnecessary bump.
This can be avoided by using ^1.14 instead.
|
I haven't seen an MSRV specified anywhere. Happy to reduce the minimum version of once_cell if maintainers prefer. |
|
Druid is experimental, so I have no problem advancing the MSRV. I'm happy to see stuff move forward. |
|
So can this be merged then? :) |
|
Rebased, and lowered the minimum version for |
cmyr
approved these changes
Oct 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
lazy_staticis increasingly getting replaced byonce_celland it's nice not to have multiple dependencies for the same thing.