Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We added super -> meta for GTK in #331, however we didn't convert the modifier state. This has left inconsistency for super key events from GTK which is converted to a regular meta key by us. This causes issues in lapce when super key is used as a modifier key, e.g: when adding a key binding for save by pressing
super + s
, onlys
is captured as shown below:before this fix - press
super + s
:after this fix - press
super + s
:We can also see the issue in the example app event_viewer:
before this fix - press
ctrl
key:before this fix - press
super
key:after this fix - press
super
key: