Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows: file open dialog multiselect fix #2332

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

ppykalo
Copy link

@ppykalo ppykalo commented Jan 16, 2023

Using multi selection option for SHOW_OPEN_PANEL command on Windows correctly generates commands::OPEN_FILES now. Previously commands::OPEN_PANEL_CANCELLED was generated when more than one file was selected.

@xStrom xStrom added shell/win concerns the Windows backend S-needs-review waits for review labels Jan 16, 2023
Copy link
Member

@xStrom xStrom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking this on. For now I have just a few minor notes. I'll do a deeper review later.

@@ -139,6 +139,7 @@ You can find its changes [documented below](#070---2021-01-01).
- X11: window focus events ([#1938] by [@Maan2003]
- Preserve the aspect ratio of a clipped region in an Image ([#2195] by [@barsae])
- GTK: Hot state now properly resets when the mouse leaves the window via an occluded part. ([#2324] by [@xStrom])
- Windows: generate `commands::OPEN_FILES` when using multiselect in file open dialog. ([#2332] by [@ppykalo])
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately the links aren't autogenerated. Please manually define [#2332] at the bottom of the file.

path: os_str.into(),
.map(|s| FileInfo {
// `get_file_dialog_path` guarantees that save dialogs
// only return on path
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// only return on path
// only return one path

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-needs-review waits for review shell/win concerns the Windows backend
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants