Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use standardized Druid naming convention. #2337

Merged
merged 2 commits into from
Jan 27, 2023
Merged

Use standardized Druid naming convention. #2337

merged 2 commits into from
Jan 27, 2023

Conversation

xStrom
Copy link
Member

@xStrom xStrom commented Jan 17, 2023

The naming convention was agreed upon years ago:

  • Druid is a proper name and always capitalized
    • Except when referencing the crate druid in which case we stylize it
    • Except when referencing the crate druid-shell in which case we stylise that too

This PR resolves most of the cases where this convention was not followed.

@xStrom xStrom added docs concerns documentation S-needs-review waits for review labels Jan 17, 2023
@xStrom xStrom added this to the Release 0.8 milestone Jan 23, 2023
longmathemagician
longmathemagician approved these changes Jan 26, 2023
View reviewed changes
Copy link
Contributor

@longmathemagician longmathemagician left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Passes case-sensitive searches & a manual once-over, marking as approved.

@longmathemagician longmathemagician removed the S-needs-review waits for review label Jan 26, 2023
@xStrom xStrom merged commit 2cd22fb into linebender:master Jan 27, 2023
@xStrom xStrom deleted the doc-fixes branch January 27, 2023 17:59
xStrom added a commit to xStrom/druid that referenced this pull request Jan 27, 2023
@xStrom
Add changelog entry for linebender#2337.
b6c3f11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@longmathemagician longmathemagician longmathemagician approved these changes

@jaredoconnell jaredoconnell jaredoconnell approved these changes

Assignees
No one assigned
Labels
docs concerns documentation
Projects
None yet
Milestone
Release 0.8
Development

Successfully merging this pull request may close these issues.
3 participants
@xStrom @longmathemagician @jaredoconnell