Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Env docs #796

Merged
merged 2 commits into from
Apr 3, 2020
Merged

Improve Env docs #796

merged 2 commits into from
Apr 3, 2020

Conversation

luleyleo
Copy link
Collaborator

@luleyleo luleyleo commented Apr 3, 2020

I've added the bullet points for the Env chapter in the book also to the Rust docs, this Closes #790
Also I've added a small example to Key, removed some whitespace form the EnvScope example and hid the env_scope override by WidgetExt which irritated me 😅 and does not seem useful to the user.

Copy link
Member

@cmyr cmyr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only the tiniest suggestion, thanks for this!

/// });
/// }
/// ```
///
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

excellent, thanks!

druid/src/widget/env_scope.rs Outdated Show resolved Hide resolved
Co-Authored-By: Colin Rofls <[email protected]>
@cmyr cmyr merged commit 1a7f76e into linebender:master Apr 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add items from the env section of book to the docs in env.rs
2 participants