Required is more like a suggestion

This updates DesignSpaceDocument to allow inputs where sources do not
have names; we will autogenerate names if they are missing.

src/designspace.rs

@@ -83,7 +83,7 @@ pub struct Source {
     #[serde(rename = "@stylename")]
     pub stylename: Option<String>,
     /// A unique name that can be used to identify this font if it needs to be referenced elsewhere.
-    #[serde(rename = "@name")]
+    #[serde(rename = "@name", default = "serde_impls::generate_missing_source_name")]
     pub name: String,
     /// A path to the source file, relative to the root path of this document.
     ///
@@ -162,6 +162,8 @@ impl DesignSpaceDocument {
 }
 
 mod serde_impls {
+    use std::sync::atomic::AtomicU64;
+
     use super::{Axis, Dimension, Instance, Source};
     use serde::{Deserialize, Deserializer};
 
@@ -208,6 +210,17 @@ mod serde_impls {
         }
         Helper::deserialize(deserializer).map(|x| x.source)
     }
+
+    /// Generate a unique name for a source.
+    ///
+    /// We do not make guarantees about what name will be assigned to a given
+    /// source, only that it will be unique within this process. If the designer
+    /// cares, they should provide a name explicitly.
+    pub fn generate_missing_source_name() -> String {
+        static COUNTER: AtomicU64 = AtomicU64::new(0);
+        let next_n = COUNTER.fetch_add(1, std::sync::atomic::Ordering::Relaxed);
+        format!("unnamed_source_{next_n}")
+    }
 }
 
 #[cfg(test)]
@@ -265,4 +278,12 @@ mod tests {
     fn load_with_no_instances() {
         DesignSpaceDocument::load("testdata/no_instances.designspace").unwrap();
     }
+
+    #[test]
+    fn required_was_like_just_a_suggestion_okay() {
+        let ds = DesignSpaceDocument::load("testdata/no_source_names.designspace").unwrap();
+        assert!(ds.sources[0].name.starts_with("unnamed_source_"));
+        assert!(ds.sources[1].name.starts_with("unnamed_source_"));
+        assert_ne!(ds.sources[0].name, ds.sources[1].name);
+    }
 }

testdata/no_source_names.designspace

@@ -0,0 +1,35 @@
+<?xml version='1.0' encoding='UTF-8'?>
+<designspace format="4.1">
+  <axes>
+    <axis tag="wght" name="Weight" minimum="400" maximum="700" default="400"/>
+  </axes>
+  <sources>
+    <source filename="TestFamily-Regular.ufo" familyname="Test Family" stylename="Regular">
+            <location>
+        <dimension name="Weight" xvalue="400"/>
+      </location>
+    </source>
+    <source filename="TestFamily-Bold.ufo" familyname="Test Family" stylename="Bold">
+      <location>
+        <dimension name="Weight" xvalue="700"/>
+      </location>
+    </source>
+  </sources>
+  <instances>
+    <instance name="Test Family Regular" familyname="Test Family" stylename="Regular" filename="instance_ufos/TestFamily-Regular.ufo" stylemapfamilyname="Test Family" stylemapstylename="regular">
+      <location>
+        <dimension name="Weight" xvalue="400"/>
+      </location>
+      <kerning/>
+      <info/>
+
+    </instance>
+    <instance name="Test Family Bold" familyname="Test Family" stylename="Bold" filename="instance_ufos/TestFamily-Bold.ufo" stylemapfamilyname="Test Family" stylemapstylename="bold">
+      <location>
+        <dimension name="Weight" xvalue="700"/>
+      </location>
+      <kerning/>
+      <info/>
+    </instance>
+  </instances>
+</designspace>