Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Layer::clear and ::get_or_create #113

Merged
merged 2 commits into from
May 1, 2021
Merged

Add Layer::clear and ::get_or_create #113

merged 2 commits into from
May 1, 2021

Conversation

madig
Copy link
Collaborator

@madig madig commented Apr 30, 2021

For easier layer handling.

@github-actions
Copy link

🗜 Bloat check ⚖️

Comparing 4e39b94 against d0d350b

target old size new size difference
target/release/examples/open_ufo 1.76 MB 1.76 MB -152 Bytes (-0.01%)
target/debug/examples/open_ufo 7.18 MB 7.18 MB ---

cmyr
cmyr approved these changes Apr 30, 2021
View reviewed changes
Copy link
Member

@cmyr cmyr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, a few comments inline :)

src/layer.rs Outdated Show resolved Hide resolved
src/layer.rs Show resolved Hide resolved
@madig
Drop the _mut
dd2e111 
There won't be an immutable version because creation always needs mut.
@madig madig changed the title Add Layer::clear and ::get_or_create_mut Add Layer::clear and ::get_or_create May 1, 2021
@github-actions
Copy link

github-actions bot commented May 1, 2021

🗜 Bloat check ⚖️

Comparing 587cdf1 against d0d350b

target old size new size difference
target/release/examples/open_ufo 1.76 MB 1.76 MB -160 Bytes (-0.01%)
target/debug/examples/open_ufo 7.18 MB 7.18 MB ---

@madig madig merged commit 1c7e347 into master May 1, 2021
@madig madig deleted the easier-layer-creation-and-clearance branch May 1, 2021 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmyr cmyr cmyr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@madig @cmyr