Layer API improvements and fixups #121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmyr
force-pushed
the
layer-api-improvements
branch
from
ae33375
to
e41d717
Compare
madig
reviewed
May 11, 2021
madig
reviewed
May 11, 2021
src/layer.rs
Outdated
| @@ -350,7 +359,7 @@ impl Layer { | |||
| } | |||
|
|
|||
| /// Returns a reference the glyph with the given name, if it exists. | |||
| pub fn get_glyph<K>(&self, glyph: &K) -> Option<&Arc<Glyph>> | |||
| pub fn glyph<K>(&self, glyph: &K) -> Option<&Arc<Glyph>> | |||
There was a problem hiding this comment.
Wouldn't get be more appropriate? Layers are basically HashMaps with fixed types...
There was a problem hiding this comment.
I think there are enough other things hanging of a layer that just 'get' would be unclear; it could be the layer's name, or it's path, or something from the lib...
There was a problem hiding this comment.
Then I actually advocate keeping "get_glyph" because it is clear. Otherwise, I'll bite my tongue now.
madig
reviewed
May 11, 2021
cmyr
force-pushed
the
layer-api-improvements
branch
from
e41d717
to
0e73c3b
Compare
cmyr
force-pushed
the
layer-api-improvements
branch
from
0e73c3b
to
c6b6e03
Compare
- Added LayerSet::new - Added Layer::rename_glyph - Fixed bug where get_glyph_mut used Arc::get_mut instead of Arc::make_mut - Renamed iter_contents & iter_contents_mut -> iter & iter_mut - Removed deprecated method A few other things along these lines
cmyr
force-pushed
the
layer-api-improvements
branch
from
c6b6e03
to
8784ce1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few other things along these lines
this is also split off from #114