-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Serialization normalizations #126
Conversation
2dfe9c0
to
c855651
Compare
c855651
to
e006785
Compare
oh no! I hadn't noticed this 😆 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool, this all looks sensible. Maybe take a look at my patches and see if there's anything interesting in there, to you?
I'll take a look at this lib-ordering business. Do you know if it's recursive? That is, if the lib contains nested dictionaries, is everything sorted during deserialization?
I think dictionary keys are always sorted inside a lib 🤔 |
e006785
to
aab411d
Compare
I copied your |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool, yea, let's keep the test because I will work on getting it passing.
Move more closely to ufonormalizer output.
I'm a bit mystified by our custom lib writing code. Why does the lib section end up unordered? It should be sorted alphabetically and I thought that's what plist was doing.
Closes #125
Closes #105