Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci] Run clippy against all targets, check docs #154

Merged
merged 1 commit into from
Aug 4, 2021

Conversation

cmyr
Copy link
Member

@cmyr cmyr commented Aug 4, 2021

We weren't doing this, which means our tests and examples were
un-clippy'd. They are now clippy'd.

We also now deny missing docs.

@cmyr cmyr force-pushed the more-expansive-clippy branch 2 times, most recently from 4a5152f to 8355bc4 Compare August 4, 2021 19:05
@github-actions
Copy link

github-actions bot commented Aug 4, 2021

🗜 Bloat check ⚖️

Comparing 1e04203 against 5237343

target old size new size difference
target/release/examples/load_save 1.75 MB 1.75 MB ---
target/debug/examples/load_save 8.12 MB 8.12 MB ---

@github-actions
Copy link

github-actions bot commented Aug 4, 2021

🗜 Bloat check ⚖️

Comparing 9533fd1 against 5237343

target old size new size difference
target/release/examples/load_save 1.75 MB 1.75 MB ---
target/debug/examples/load_save 8.12 MB 8.12 MB ---

1 similar comment
@github-actions
Copy link

github-actions bot commented Aug 4, 2021

🗜 Bloat check ⚖️

Comparing 9533fd1 against 5237343

target old size new size difference
target/release/examples/load_save 1.75 MB 1.75 MB ---
target/debug/examples/load_save 8.12 MB 8.12 MB ---

@github-actions
Copy link

github-actions bot commented Aug 4, 2021

🗜 Bloat check ⚖️

Comparing 4158747 against 5237343

target old size new size difference
target/release/examples/load_save 1.75 MB 1.75 MB ---
target/debug/examples/load_save 8.12 MB 8.12 MB ---

We weren't doing this, which means our tests and examples were
un-clippy'd. They are now clippy'd.

We also now deny missing docs.
@github-actions
Copy link

github-actions bot commented Aug 4, 2021

🗜 Bloat check ⚖️

Comparing cbad21d against 5237343

target old size new size difference
target/release/examples/load_save 1.75 MB 1.75 MB ---
target/debug/examples/load_save 8.12 MB 8.12 MB ---

@cmyr cmyr merged commit c473600 into master Aug 4, 2021
@cmyr cmyr deleted the more-expansive-clippy branch August 4, 2021 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant