Fix bug where glyphs were saved twice #160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As pointed out in #157.
|
ping @madig in case you were profiling I/O with the latest main branch |
|
Thanks, but I haven't gotten around to profiling at all :( |
|
So, I did a very quick replacement in my test program of Edit: wait, I do something stupid in the program, retesting tomorrow. Edit2: Retesting, I see very little difference. Maybe because Rust spends most of its time twiddling its thumbs anyway? |
|
yea, I profiled this and it looks like rayon is a small win, which I interpret as meaning that the bottleneck is actually writing to disk, which makes sense. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As pointed out in #157.