Remove submodules #166
Merged
Remove submodules #166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We keep MutatorSansLightWide.ufo, which is now commited directly to testdata/.
cmyr
force-pushed
the
remove-submodules
branch
from
0f4a2fc
to
177f682
Compare
|
You can also leave the files as text but enforce LF line endings. Not sure what is better. |
|
I chose this approach because it would also let us have test data that uses CRLF. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This includes the commits from #161 because I didn't want to need to rebase that, and I want to test this all rolled up; if this works then I'll drop those commits and merge, and we can merge #161 separately.Okay, this removes submodules and adds a
.gitattributesfile so that git doesn't touch line endings on.fea,.plist, and.gliffiles in this repository.