MetaInfo: creator is optional now #190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmyr
reviewed
Sep 30, 2021
| @@ -77,7 +77,7 @@ fn is_zero(v: &u32) -> bool { | |||
| impl Default for MetaInfo { | |||
| fn default() -> Self { | |||
| MetaInfo { | |||
| creator: DEFAULT_METAINFO_CREATOR.to_string(), | |||
| creator: Some(DEFAULT_METAINFO_CREATOR.to_string()), | |||
There was a problem hiding this comment.
Hm, and set the creator on saving? I'd prefer to keep the explicit norad reference, since norad is the only user of it currently.
| @@ -64,7 +64,7 @@ pub enum FormatVersion { | |||
| #[derive(Debug, Clone, Serialize, Deserialize, PartialEq)] | |||
| #[serde(rename_all = "camelCase")] | |||
| pub struct MetaInfo { | |||
| pub creator: String, | |||
| pub creator: Option<String>, | |||
There was a problem hiding this comment.
I think this is right, but in line with the other changes you've been making we could also just treat the empty string as none. (I prefer this way, though, it's more explicit and more "correct".
There was a problem hiding this comment.
Mh, an empty string would still land in the serialized stream unless I stop serde; and the spec doesn't say that the field must be non-empty 🤔
|
OK to merge? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See unified-font-object/ufo-spec#192.