Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make util module pub(crate) #215

Merged
merged 1 commit into from
Dec 21, 2021
Merged

Make util module pub(crate) #215

merged 1 commit into from
Dec 21, 2021

Conversation

cmyr
Copy link
Member

@cmyr cmyr commented Dec 20, 2021

We don't need these to be part of the public api for 1.0, and I'm not sure they were intended to be public in the first place. I might have used them in runebender at some point, but I don't see them used now. 🤷

@github-actions
Copy link

🗜 Bloat check ⚖️

Comparing fc1428f against 5f0cc9c

target old size new size difference
target/release/examples/load_save 1.9 MB 1.9 MB -64 Bytes (-0.00%)
target/debug/examples/load_save 8.55 MB 8.55 MB -136 Bytes (-0.00%)

@cmyr cmyr merged commit 29053f7 into master Dec 21, 2021
@cmyr cmyr deleted the make-util-private branch December 21, 2021 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants