Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Miscellaneous changes #239

Merged
merged 2 commits into from
Jan 7, 2022
Merged

Miscellaneous changes #239

merged 2 commits into from
Jan 7, 2022

Conversation

madig
Copy link
Collaborator

@madig madig commented Jan 7, 2022

Two small changes I did while experimenting with the glif parser.

@github-actions
Copy link

github-actions bot commented Jan 7, 2022

🗜 Bloat check ⚖️

Comparing fb2c891 against 861fa73

target old size new size difference
target/release/examples/load_save 1.88 MB 1.88 MB 304 Bytes (0.02%)
target/debug/examples/load_save 8.54 MB 8.55 MB 1.01 KB (0.01%)

cmyr
cmyr approved these changes Jan 7, 2022
View reviewed changes
Copy link
Member

@cmyr cmyr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@madig madig changed the base branch from support-glif-format-minor to master January 7, 2022 16:54
@github-actions
Copy link

github-actions bot commented Jan 7, 2022

🗜 Bloat check ⚖️

Comparing 6c15a7f against 47ff135

target old size new size difference
target/release/examples/load_save 1.88 MB 1.88 MB 256 Bytes (0.01%)
target/debug/examples/load_save 8.54 MB 8.55 MB 1.02 KB (0.01%)

@madig madig merged commit d1fd5b1 into master Jan 7, 2022
@madig madig deleted the misc-changes branch January 7, 2022 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmyr cmyr cmyr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@madig @cmyr