Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Take glyph name crate-public #267

Merged
merged 6 commits into from
Jul 15, 2022
Merged

Take glyph name crate-public #267

merged 6 commits into from
Jul 15, 2022

Conversation

madig
Copy link
Collaborator

@madig madig commented Jul 13, 2022 •
edited
Loading

Closes #266

cmyr
cmyr approved these changes Jul 14, 2022
View reviewed changes
Copy link
Member

@cmyr cmyr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some notes but this looks good 👍

src/glyph/mod.rs Outdated Show resolved Hide resolved
src/glyph/mod.rs Show resolved Hide resolved
tests/save.rs Outdated Show resolved Hide resolved
Base automatically changed from prefill-layerset-paths to master July 15, 2022 15:14
@madig madig merged commit 667a109 into master Jul 15, 2022
@madig madig deleted the privatize-glyph-names branch July 15, 2022 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmyr cmyr cmyr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Layer::get_glyph_mut allows user to change glyph name without updating Layer.glyphs
2 participants
@madig @cmyr