Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make name-to-file-name conversion functions public #282

Merged
merged 1 commit into from
Nov 30, 2022
Merged

Make name-to-file-name conversion functions public #282

merged 1 commit into from
Nov 30, 2022

Conversation

cmyr
Copy link
Member

@cmyr cmyr commented Nov 30, 2022

anthrotype
anthrotype approved these changes Nov 30, 2022
View reviewed changes
Copy link
Collaborator

@anthrotype anthrotype left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks! not quite, see other comment

anthrotype
anthrotype requested changes Nov 30, 2022
View reviewed changes
Copy link
Collaborator

@anthrotype anthrotype left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what i'd like is to make user_name_to_file_name public directly, so we can use with other suffixes than .glif

@cmyr
Make user_name_to_file_name public, tweak signature
cce003d 
The function now takes a closure instead of a hashset, and now works
with any AsRef<str> type, anod not just Name; this makes it more
suitable as public API.
anthrotype
anthrotype approved these changes Nov 30, 2022
View reviewed changes
Copy link
Collaborator

@anthrotype anthrotype left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for real now!

@cmyr cmyr merged commit 8a464f4 into master Nov 30, 2022
@cmyr cmyr deleted the pub-name-to-file-name branch November 30, 2022 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anthrotype anthrotype anthrotype approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cmyr @anthrotype