Update quickxml again #295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rsheeter
approved these changes
Mar 17, 2023
In the previous version of quick-xml there was an issue that prevented deserialization of Option<Vec<_>>. We worked around this by changing our API, but that change was not an improvement, and the issue is fixed in quick-xml 0.28. Since I intend to yank norad 0.9, we can revert that change, providing a better upgrade path for our users.
cmyr
force-pushed
the
update-quickxml-again
branch
from
4871ec9
to
345c50f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This involves one breaking change, which is actually reverting a breaking change made in 0.9. From the relevant commit: