Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[designspace] Stop generating source/instance names #313

Merged
merged 1 commit into from
Jul 28, 2023
Merged

Conversation

cmyr
Copy link
Member

@cmyr cmyr commented Jul 25, 2023

closes #312

@Hoolean
Copy link

Hoolean commented Jul 27, 2023

Thanks for putting this PR together Colin, you beat me to it! Nice to see that only minimal changes are needed in fontc too 👍

@RickyDaMa
Copy link
Collaborator

Looks good to me, if this gets merged I'll rebase my PR over it :)

@cmyr cmyr merged commit 843ca05 into master Jul 28, 2023
@cmyr cmyr deleted the no-generated-names branch July 28, 2023 14:43
@anthrotype
Copy link
Collaborator

Nice to see that only minimal changes are needed in fontc too

fontc relies on those name attributes being set to non Optional values (e.g. it uses the source.name as a unique way to identify specific source elements, for the filename may well be the same for multiple sources referencing different layers from the same .ufo), so this is a breaking change.. If norad is unwilling to provide these unique name attributes fontc will have to do the same dance with AtomicU64. It's not sufficient to fallback to a constant "placeholder_source_name" because that might well clash.

@cmyr
Copy link
Member Author

cmyr commented Aug 7, 2023

I have a patch for fontc written, and I do think that this belongs there, instead of norad.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stop generating placeholder names to sources/instances
4 participants