Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ser/de Designspace rules #318

Merged
merged 3 commits into from
Aug 23, 2023
Merged

Ser/de Designspace rules #318

merged 3 commits into from
Aug 23, 2023

Conversation

madig
Copy link
Collaborator

@madig madig commented Aug 22, 2023

This reads and writes rules in Designspaces.

Does not support standalone <condition> elements outside a <conditionset> because it's annoying to implement.

Specification: https://fonttools.readthedocs.io/en/latest/designspaceLib/xml.html#rules-element

Copy link
Collaborator

@RickyDaMa RickyDaMa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks sane to me, maybe just a couple mishaps in the doc strings?

src/designspace.rs Outdated Show resolved Hide resolved
src/designspace.rs Outdated Show resolved Hide resolved
src/designspace.rs Outdated Show resolved Hide resolved
Copy link
Member

@cmyr cmyr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One note, otherwise lgtm!

src/designspace.rs Show resolved Hide resolved
@madig madig merged commit 4e954df into master Aug 23, 2023
4 checks passed
@madig madig deleted the add-ds-rules branch August 23, 2023 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants