Implement TryFrom<String> for Name
#347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allows for re-using the allocated memory if you already have the owned type
Fixes clippy lint
cmyr
approved these changes
May 23, 2024
There was a problem hiding this comment.
This looks fine, but unfortunately I do not believe it reuses the allocation? For instance it doesn't appear that From<String> for Arc<str> reuses an allocation (I'm inferring this, but the docs imply that the data is copied to the new allocation)
|
That's fair, I'd never actually delved into the Maybe it just helps the compiler optimise it, since it can see the allocation for the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows for re-using the allocated memory if you already have the owned type, and also avoids allocating in the error case 😎
This addresses that invasive brain thought I get when I have to rely on the compiler to realise it can re-use an allocation, instead of explicitly having a code path for it
This PR also contains an unrelated commit to fix a clippy lint