Implement Glif v1 upconversion and minor fixups #51

madig · 2020-06-21T17:30:21Z

This PR implements:

A few miscellaneous fixes to make output more diff-less compared to the reference libraries.
Ensure a glifs' note and lib elements are present once and that a v1 contour has no attributes.
Loading and upconverting Glif v1 files, with single-point move-type contours being upgraded to anchors, as recommended in http://unifiedfontobject.org/versions/ufo3/glyphs/glif/#converting-implied-anchors-in-glif-1-to-glif-2-anchor-elements.

Matches what ufoLib/defcon is doing.

cmyr

A few little suggestions but this looks good!

src/glyph/parse.rs

madig added 6 commits June 21, 2020 18:11

Order fontinfo attributes so that there's no diff to ufoLib

dff5ee2

Serialize contours, then components

752e733

Matches what ufoLib/defcon is doing.

parse_outline: error on any unexpected element

e695291

Ensure lib and note are present once.

7e983e8

parse_advance: check for duplicate element first

73f5323

Implement Glif v1 loading and v2 uppconversion

29d4f67

cmyr approved these changes Jun 24, 2020

View reviewed changes

src/glyph/parse.rs Outdated Show resolved Hide resolved

src/glyph/parse.rs Outdated Show resolved Hide resolved

madig added 2 commits July 1, 2020 22:13

Simplify upgraded anchor insertion

8c901e5

Refactor v1 anchor logic into function

af4cdfd

madig merged commit b63e284 into master Jul 1, 2020

madig deleted the glifv1-and-minor-fixups branch July 1, 2020 21:21

Provide feedback