Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Properly account for identifier and lib arguments #82

Merged
merged 1 commit into from
Feb 7, 2021
Merged

Properly account for identifier and lib arguments #82

merged 1 commit into from
Feb 7, 2021

Conversation

madig
Copy link
Collaborator

@madig madig commented Feb 6, 2021

Closes #81.

@github-actions
Copy link

github-actions bot commented Feb 6, 2021

🗜 Bloat check ⚖️

Comparing bcd8141 against 7cdb9ae

target old size new size difference
target/release/examples/open_ufo 1.55 MB 1.56 MB 16.7 KB (1.06%)
target/debug/examples/open_ufo 6.96 MB 6.97 MB 17.62 KB (0.25%)

cmyr
cmyr approved these changes Feb 7, 2021
View reviewed changes
Copy link
Member

@cmyr cmyr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That works, thanks!

@madig madig merged commit 191704a into master Feb 7, 2021
@madig madig deleted the proper-lib-id-news branch February 7, 2021 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmyr cmyr cmyr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

new constructors for Contour, ContourPoint and possibly others need to deal with identifier/lib args
2 participants
@madig @cmyr