Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

I don't think the fontinfo and glyph mods need to be pub? #99

Merged
merged 1 commit into from
Apr 5, 2021
Merged

I don't think the fontinfo and glyph mods need to be pub? #99

merged 1 commit into from
Apr 5, 2021

Conversation

madig
Copy link
Collaborator

@madig madig commented Apr 3, 2021 •
edited
Loading

Does error need to be pub? 🤔

@github-actions
Copy link

github-actions bot commented Apr 3, 2021

🗜 Bloat check ⚖️

Comparing 321f62d against 9abfc96

target old size new size difference
target/release/examples/open_ufo 1.76 MB 1.76 MB ---
target/debug/examples/open_ufo 7.15 MB 7.15 MB ---

@cmyr
Copy link
Member

cmyr commented Apr 4, 2021

I have a line in runebender, use norad::glyph::{Contour, ContourPoint, Glyph, GlyphName, PointType};. I assume all these types are now exported elsewhere?

@madig
Copy link
Collaborator Author

madig commented Apr 4, 2021 via email

@madig
Copy link
Collaborator Author

madig commented Apr 4, 2021 •
edited
Loading

As in, use norad::{Contour, ContourPoint, Glyph, GlyphName, PointType};.

cmyr
cmyr approved these changes Apr 5, 2021
View reviewed changes
Copy link
Member

@cmyr cmyr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sounds good!

@madig madig merged commit c3c54ab into master Apr 5, 2021
@madig madig deleted the depub-some-mods branch April 5, 2021 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmyr cmyr cmyr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@madig @cmyr