Skip to content

Commit

Permalink
Move around the lints
Browse files Browse the repository at this point in the history
  • Loading branch information
DJMcNab committed Aug 5, 2024
1 parent 10b0f7a commit 73c01ec
Showing 1 changed file with 15 additions and 19 deletions.
34 changes: 15 additions & 19 deletions Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,14 @@ rust.unused_import_braces = "warn"
rust.trivial_numeric_casts = "warn"
rust.unused_macro_rules = "warn"
rust.variant_size_differences = "warn"
rust.let_underscore_drop = "warn"
rust.missing_debug_implementations = "warn"
rust.unused_qualifications = "warn"
rust.single_use_lifetimes = "warn"
rust.missing_docs = "warn"
rust.unreachable_pub = "warn"
rust.unnameable_types = "warn"
rust.elided_lifetimes_in_paths = "warn"

clippy.allow_attributes_without_reason = "warn"
clippy.collection_is_never_read = "warn"
Expand All @@ -70,33 +78,17 @@ clippy.same_functions_in_if_condition = "warn"
clippy.semicolon_if_nothing_returned = "warn"
clippy.should_panic_without_expect = "warn"
clippy.unseparated_literal_suffix = "warn"

# Follow-ups for their own PRs, too noisy to go in lint group PR

rust.let_underscore_drop = "warn"
rust.missing_debug_implementations = "warn"
rust.unused_qualifications = "warn"
rust.single_use_lifetimes = "warn"

clippy.dbg_macro = "warn"
clippy.match_same_arms = "warn"
# clippy.cast_possible_truncation = "warn"
clippy.missing_assert_message = "warn"
clippy.return_self_not_must_use = "warn"
clippy.wildcard_imports = "warn"
rust.elided_lifetimes_in_paths = "warn"
# clippy.use_self = "warn"

# Aspirational lints, not enabled for one reason or another

rust.missing_docs = "warn"
rust.unreachable_pub = "warn"
rust.unnameable_types = "warn"
clippy.todo = "warn"
clippy.missing_errors_doc = "warn"
clippy.missing_panics_doc = "warn"
clippy.partial_pub_fields = "warn"
clippy.shadow_unrelated = "warn"
# clippy.use_self = "warn"

# This catches duplicated dependencies in the tree, which we don't have much control over
# We should use cargo deny for this, anyway
Expand All @@ -110,6 +102,10 @@ clippy.cargo = { level = "warn", priority = -1 }
# clippy.print_stdout = "warn" # Note that this is allowed in Masonry
# clippy.print_stderr = "warn" # Note that this is allowed in Masonry

# Explicit per-crate exceptions
# Should be manually checked occasionally. Most enums are correctly exhaustive, as this is a vocabulary crate.
## Explicit per-crate exceptions, should be manually checked occasionally.
# Most enums are correctly exhaustive, as this is a vocabulary crate.
# clippy.exhaustive_enums = "warn"
# There are lots of conversion to u8 color field, which in degenerate cases might not work
# properly, but generally are fine.
# E.g. `with_alpha_factor` sets the alpha to `0` for a negative provided `alpha`
# clippy.cast_possible_truncation = "warn"

0 comments on commit 73c01ec

Please sign in to comment.