Bump kurbo and remove Stroke #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now that kurbo 0.10 can represent stroke styles, remove it from this crate. Note that this also removes the `scale` parameter, which was used to model the non-scaling stroke vector effect in SVG. The `Fill` and `Style` enums are kept, as fill rule represents a rendering choice and not path geometry, and is not (at least at the moment) represented in kurbo.
dfrg
approved these changes
Oct 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that kurbo 0.10 can represent stroke styles, remove it from this crate. Note that this also removes the
scaleparameter, which was used to model the non-scaling stroke vector effect in SVG.The
FillandStyleenums are kept, as fill rule represents a rendering choice and not path geometry, and is not (at least at the moment) represented in kurbo.