WIP: Set kern group #244
WIP: Set kern group #244
Conversation
| @@ -356,6 +358,33 @@ impl Workspace { | |||
| } | |||
| } | |||
|
|
|||
| pub fn set_glyph_group(&mut self, prefix: &str, glyph_name: GlyphName, group_name: String) { | |||
There was a problem hiding this comment.
This definitely reenforces my suspicion that we should find some better way to store these. 🤔
There was a problem hiding this comment.
I agree, though it's hard to think of a good clean place to introduce yet another intermediate datastructure
| @@ -63,13 +63,13 @@ fn selected_glyph_widget() -> impl Widget<GlyphDetail> { | |||
| .with_child( | |||
| Flex::row() | |||
| .with_child( | |||
| Label::new("kern group") | |||
| Label::dynamic(|d: &GlyphDetail, _| (*d.kern2_group).to_string()) | |||
There was a problem hiding this comment.
so getting the editing working should be a two step process:
-
use
EditableLabel:EditableLabel::new( |s: &String, _: &_| s.to_string(), |s| Some(s.to_string()) ) .lens(GlyphDetail::kern1_group)
-
Add some controller that sends a message to rename the glyph when the data changes.
That should get this working, I think?
There was a problem hiding this comment.
That's what I thought, though it involves writing two more dummy lenses in GlyphDetail I think.
There was a problem hiding this comment.
Yep, that sounds right. I don't love it, and also, it works,
No description provided.