Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flickering artifacts with paper-1 #376

Closed
raphlinus opened this issue Oct 11, 2023 · 0 comments · Fixed by #385
Closed

Flickering artifacts with paper-1 #376

raphlinus opened this issue Oct 11, 2023 · 0 comments · Fixed by #385

Comments

@raphlinus
Copy link
Contributor

raphlinus commented Oct 11, 2023 •
edited
Loading

The paper-1 example from MPVG has flickering artifacts, seemingly 16x16 boxes that are rendered wrong. Experimenting with CPU shaders shows that the artifacts appear when flattening is on the GPU, and disappear when flattening is CPU, everything before that on CPU, everything after on GPU. However, I don't suspect flattening is what's going wrong, it's more likely that flickering is dependent on the order of LineSoup entries.

These artifacts seem to appear only at the default zoom, at other zoom settings they go away.

Screenshot 2023-10-10 at 7 39 09 PM
raphlinus added a commit that referenced this issue Oct 12, 2023
@raphlinus
Improve numerical robustness of conservative line rasterization
714fde9 
Apply additional logic to make sure that first and last tiles of conservative line rasterization land on the right tile.

Note: this fixes the assert and should avoid artifacts, but still doesn't render the poland svg correctly (there are black splotches).

Fixes #376 and #378
@raphlinus raphlinus mentioned this issue Oct 12, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improve numerical robustness of conservative line rasterization linebender/vello
1 participant
@raphlinus